wForget commented on code in PR #5410:
URL: https://github.com/apache/kyuubi/pull/5410#discussion_r1357633767
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/kyuubi/StageStatus.scala:
##########
@@ -27,3 +27,8 @@ class SparkStageInfo(val stageId: Int, val numTasks: Int) {
var numActiveTasks = new AtomicInteger(0)
var numCompleteTasks = new AtomicInteger(0)
}
+
+
+class SparkJobInfo(val numStages: Int, val stageIds: Seq[Int]) {
+ var numCompleteStages = new AtomicInteger(0)
+}
Review Comment:
The file must end with newline, please add it.
check error:
```
[INFO] --- scalastyle-maven-plugin:1.0.0:check (default-cli) @
kyuubi-spark-sql-engine_2.12 ---
error
file=/home/runner/work/kyuubi/kyuubi/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/kyuubi/StageStatus.scala
message=File must end with newline character
```
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/kyuubi/SparkConsoleProgressBar.scala:
##########
@@ -72,6 +73,22 @@ class SparkConsoleProgressBar(
}
}
+ /**
+ * Use stageId to find stage's jobId
+ * @param stageId stageId
+ * @return jobId,if not exists, return -1
+ */
+ private def findJobId(stageId: Int): Int = {
Review Comment:
return `Option[Int]` then use `isEmpty/isDefined` to determine whether it is
empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
