yaooqinn commented on code in PR #5418:
URL: https://github.com/apache/kyuubi/pull/5418#discussion_r1360217670


##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RuleApplyPermanentViewMarker.scala:
##########
@@ -36,6 +38,15 @@ class RuleApplyPermanentViewMarker extends Rule[LogicalPlan] 
{
     plan mapChildren {
       case p: PermanentViewMarker => p
       case permanentView: View if hasResolvedPermanentView(permanentView) =>
+        permanentView.transformAllExpressions {
+          case scalarSubquery: ScalarSubquery =>
+            scalarSubquery.plan.transformDown {
+              case p =>
+                p.setTagValue(PERMANNENT_VIEW_SUBQUERY_TAG, true)
+                p
+            }
+            scalarSubquery
+        }

Review Comment:
   PlanSubqueries seem to happen in the planner not in the optimizer. Do you 
mean the execution.ScalarSubquery is already in analyzer instead of a logical 
one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to