yaooqinn commented on code in PR #5418:
URL: https://github.com/apache/kyuubi/pull/5418#discussion_r1360474915
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RuleApplyPermanentViewMarker.scala:
##########
@@ -36,7 +37,12 @@ class RuleApplyPermanentViewMarker extends Rule[LogicalPlan]
{
plan mapChildren {
case p: PermanentViewMarker => p
case permanentView: View if hasResolvedPermanentView(permanentView) =>
- PermanentViewMarker(permanentView, permanentView.desc)
+ val resolvedSubquery = permanentView.transformAllExpressions {
+ case scalarSubquery: ScalarSubquery =>
+ // Pass null to PermanentViewMarker to avoid check view's
ScalarSubquery.
Review Comment:
Maybe a TODO here
```
// TODO: Currently, we do not do an auth check in the subquery as the main
query part also secures it. But for performance consideration, we also
pre-check it in subqueries and fail fast with negative privileges
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
