cxzl25 commented on code in PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#discussion_r1366562892
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -700,7 +700,9 @@ SSLConnectionSocketFactory getTwoWaySSLSocketFactory()
throws SQLException {
}
private void openSession() throws SQLException {
- TOpenSessionReq openReq = new TOpenSessionReq();
+ // Server responses are the same if TProtocolVersion >=
HIVE_CLI_SERVICE_PROTOCOL_V6
Review Comment:
Kyuubi JDBC uses `HIVE_CLI_SERVICE_PROTOCOL_V10`,
`TOpenSessionReq.TOpenSessionReqStandardScheme#read` returns null because
there is no corresponding protocol version.
So there is `Required field 'client_protocol' is unset! ` in the PR
description.
https://github.com/apache/hive/blob/b02cef4fe943b9aba597dcdfd3b8f3d3a5efca3e/service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionReq.java#L580
If Kyuubi JDBC uses a lower version, HS2 will compare the currently known
version, find the minimum version number, and return it to the Client.
https://github.com/apache/hive/blob/b02cef4fe943b9aba597dcdfd3b8f3d3a5efca3e/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java#L556-L557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
