cxzl25 commented on code in PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#discussion_r1368103365


##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -700,7 +700,9 @@ SSLConnectionSocketFactory getTwoWaySSLSocketFactory() 
throws SQLException {
   }
 
   private void openSession() throws SQLException {
-    TOpenSessionReq openReq = new TOpenSessionReq();
+    // Server responses are the same if TProtocolVersion >= 
HIVE_CLI_SERVICE_PROTOCOL_V6

Review Comment:
   Kyuubi currently determines whether to return TIMEDOUT_STATE based on the 
client's protocol version.
   https://github.com/apache/kyuubi/issues/2112
   
   v7
   0.13.0
   [HIVE-6647](https://issues.apache.org/jira/browse/HIVE-6647) : Bump the 
thrift api version to V7 for HiveServer2
   
   v8
   1.2.0
   [HIVE-10037](https://issues.apache.org/jira/browse/HIVE-10037): JDBC support 
for interval expressions
   
   v9
   2.2.0
   [HIVE-12427](https://issues.apache.org/jira/browse/HIVE-12427): ResultSet 
performance
   [HIVE-14191](https://issues.apache.org/jira/browse/HIVE-14191): bump a new 
api version for ThriftJDBCBinarySerde changes
   
   
org.apache.hive.service.cli.session.HiveSessionImpl#updateIsUsingThriftJDBCBinarySerDe
   ```java
     private boolean updateIsUsingThriftJDBCBinarySerDe() {
       return 8 <= getProtocolVersion().getValue() &&
         
sessionConf.getBoolVar(ConfVars.HIVE_SERVER2_THRIFT_RESULTSET_SERIALIZE_IN_TASKS);
     }
   ```
   
   v10
   2.2.0
   [HIVE-15473](https://issues.apache.org/jira/browse/HIVE-15473): Progress Bar 
on Beeline client
   [HIVE-15906](https://issues.apache.org/jira/browse/HIVE-15906) : thrift code 
regeneration to include new protocol version
   
   v11
   3.0.0
   [HIVE-14412](https://issues.apache.org/jira/browse/HIVE-14412): Add 
timestamp with time zone
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to