bowenliang123 commented on code in PR #5490:
URL: https://github.com/apache/kyuubi/pull/5490#discussion_r1367040214
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/schema/RowSetHelper.scala:
##########
@@ -16,12 +16,20 @@
*/
package org.apache.kyuubi.engine.jdbc.schema
-import java.util
+import java.{lang, util}
+import java.sql.{Date, Types}
+import java.time.LocalDateTime
+
+import scala.collection.JavaConverters._
import org.apache.hive.service.rpc.thrift._
+import org.apache.kyuubi.util.RowSetUtils.{bitSetToBuffer, formatDate,
formatLocalDateTime}
+
abstract class RowSetHelper {
+ val nulls = new java.util.BitSet()
Review Comment:
Move back into method as local variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
