bowenliang123 commented on code in PR #5490:
URL: https://github.com/apache/kyuubi/pull/5490#discussion_r1367045896
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/operation/JdbcOperation.scala:
##########
@@ -98,15 +98,15 @@ abstract class JdbcOperation(session: Session) extends
AbstractOperation(session
override protected def afterRun(): Unit = {}
protected def toTRowSet(taken: Iterator[Row]): TRowSet = {
- val rowSetHelper = dialect.getRowSetHelper()
+ val rowSetHelper = dialect.getRowSetHelper
Review Comment:
Leave the blank quote to represent the calling rather than a value.
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/operation/JdbcOperation.scala:
##########
@@ -98,15 +98,15 @@ abstract class JdbcOperation(session: Session) extends
AbstractOperation(session
override protected def afterRun(): Unit = {}
protected def toTRowSet(taken: Iterator[Row]): TRowSet = {
- val rowSetHelper = dialect.getRowSetHelper()
+ val rowSetHelper = dialect.getRowSetHelper
rowSetHelper.toTRowSet(
taken.toList.map(_.values),
schema.columns,
getProtocolVersion)
}
override def getResultSetMetadata: TGetResultSetMetadataResp = {
- val schemaHelper = dialect.getSchemaHelper()
+ val schemaHelper = dialect.getSchemaHelper
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
