davidyuan1223 commented on PR #5549: URL: https://github.com/apache/kyuubi/pull/5549#issuecomment-1782758043
> The analysis looks reasonable to me (Sorry I have no much knowledge about the internal of Flink). > > One minor tip: use pure text as much as possible, because the picture is not searchable, it's hard to search engines for referencing and indexing. actually, the git commit history to much > Also, would you mind centralizing your analysis to the PR description? it will be included in the commit message, making it convenient for future explorers to understand the background of this change. of course, and i think we can add desc about kyuubi's flink max-rows conf. maybe there have someone makes the some problem like this bug, it can improve user to find the source problem quickly, what do you think? (maybe i need more time to manage the commit history, i have same problem in other pr, Since I'm used to idea's git tool, the time it takes me to deal with this problem may not be solved until tomorrow...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
