pan3793 commented on code in PR #5549:
URL: https://github.com/apache/kyuubi/pull/5549#discussion_r1375504937
##########
externals/kyuubi-flink-sql-engine/src/test/scala/org/apache/kyuubi/engine/flink/operation/FlinkOperationSuite.scala:
##########
@@ -637,7 +637,8 @@ abstract class FlinkOperationSuite extends
HiveJDBCTestHelper with WithFlinkTest
test("execute statement - show/stop jobs") {
if (FLINK_RUNTIME_VERSION >= "1.17") {
- withSessionConf()(Map(ENGINE_FLINK_MAX_ROWS.key -> "10"))(Map.empty) {
+ // we need set the conf's value to make sure it will not cancel stream
query before stop job
Review Comment:
```suggestion
// use a bigger value to ensure all tasks of the streaming query run
until
// we explicitly stop the job.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
