lightning-L commented on code in PR #5568:
URL: https://github.com/apache/kyuubi/pull/5568#discussion_r1377129533
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -70,6 +71,17 @@ class KyuubiRestFrontendService(override val serverable:
Serverable)
private lazy val port: Int = conf.get(FRONTEND_REST_BIND_PORT)
+ private lazy val isSecurityEnabled = {
+ val authTypes = conf.get(AUTHENTICATION_METHOD).map(AuthTypes.withName)
+ !authTypes.contains(NONE) && authTypes != Set(NOSASL)
Review Comment:
Just a trivial question, is it possible to reuse the variables defined in
`KyuubiAuthenticationFactory`.
```
private val authTypes =
conf.get(AUTHENTICATION_METHOD).map(AuthTypes.withName)
private val none = authTypes.contains(NONE)
private val noSasl = authTypes == Set(NOSASL)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
