pan3793 commented on code in PR #5568:
URL: https://github.com/apache/kyuubi/pull/5568#discussion_r1377211105
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -70,6 +71,17 @@ class KyuubiRestFrontendService(override val serverable:
Serverable)
private lazy val port: Int = conf.get(FRONTEND_REST_BIND_PORT)
+ private lazy val isSecurityEnabled = {
+ val authTypes = conf.get(AUTHENTICATION_METHOD).map(AuthTypes.withName)
+ !authTypes.contains(NONE) && authTypes != Set(NOSASL)
Review Comment:
Thanks for pointing it out, actually, I found bunches of duplicated code in
THRIFT-HTTP and RESTful protocols, I'm fixing the tests and reducing the code
duplications now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
