cxzl25 commented on code in PR #5614:
URL: https://github.com/apache/kyuubi/pull/5614#discussion_r1388810649


##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/dialect/JdbcDialect.scala:
##########
@@ -85,7 +86,9 @@ abstract class JdbcDialect extends SupportServiceLoader with 
Logging {
 
 object JdbcDialects extends Logging {
 
+  var defaultFetchSize: Int = 0
   def get(conf: KyuubiConf): JdbcDialect = {
+    defaultFetchSize = conf.get(ENGINE_JDBC_FETCH_SIZE)

Review Comment:
   This fetch size may be modified by the conf of different sessions. Can the 
fetch size be obtained in JdbcOperationManager?
   
   
https://github.com/apache/kyuubi/blob/e8e981d4abe8e3be66ac8674f5284a202388a357/externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/operation/JdbcOperationManager.scala#L44-L46



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to