bowenliang123 commented on code in PR #5614:
URL: https://github.com/apache/kyuubi/pull/5614#discussion_r1390749588
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/operation/JdbcOperationManager.scala:
##########
@@ -71,8 +79,12 @@ class JdbcOperationManager(conf: KyuubiConf) extends
OperationManager("JdbcOpera
catalog: String,
schema: String): Operation = {
val query = dialect.getSchemasOperation(catalog, schema)
+ val normalizedConf = session.asInstanceOf[JdbcSessionImpl].normalizedConf
+ val fetchSize = normalizedConf.get(ENGINE_JDBC_FETCH_SIZE.key).map(
+ _.toInt).getOrElse(
+ session.sessionManager.getConf.get(ENGINE_JDBC_FETCH_SIZE))
Review Comment:
```suggestion
val fetchSize =
normalizedConf.get(ENGINE_JDBC_FETCH_SIZE.key).map(_.toInt)
.getOrElse(session.sessionManager.getConf.get(ENGINE_JDBC_FETCH_SIZE))
```
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/operation/JdbcOperationManager.scala:
##########
@@ -100,8 +116,12 @@ class JdbcOperationManager(conf: KyuubiConf) extends
OperationManager("JdbcOpera
tableName: String,
columnName: String): Operation = {
val query = dialect.getColumnsQuery(session, catalogName, schemaName,
tableName, columnName)
+ val normalizedConf = session.asInstanceOf[JdbcSessionImpl].normalizedConf
+ val fetchSize = normalizedConf.get(ENGINE_JDBC_FETCH_SIZE.key).map(
+ _.toInt).getOrElse(
+ session.sessionManager.getConf.get(ENGINE_JDBC_FETCH_SIZE))
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
