pan3793 commented on code in PR #5809:
URL: https://github.com/apache/kyuubi/pull/5809#discussion_r1414920828
##########
externals/kyuubi-spark-sql-engine/pom.xml:
##########
@@ -72,6 +72,13 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.spark</groupId>
+ <artifactId>spark-core_${scala.binary.version}</artifactId>
+ <type>test-jar</type>
Review Comment:
we can get rid of this dependencies if we fork
`org.apache.spark.benchmark.Benchmark` from Spark
##########
externals/kyuubi-spark-sql-engine/pom.xml:
##########
@@ -72,6 +72,13 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.spark</groupId>
+ <artifactId>spark-core_${scala.binary.version}</artifactId>
+ <type>test-jar</type>
Review Comment:
we can get rid of this dependency if we fork
`org.apache.spark.benchmark.Benchmark` from Spark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
