yaooqinn commented on PR #5809: URL: https://github.com/apache/kyuubi/pull/5809#issuecomment-1840778802
@wForget You are correct about the purpose of this PR, but the benchmark itself needs to be corrected. Technically, if we introduce the Spark benchmark tool, the first line of results in each single benchmark should be the control group as it always produces 1x for `Relative`. The current test also varies the simple rule of `univariate analysis` for experiments. What I saw in the results is a mess, TBH. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
