wForget commented on code in PR #5871:
URL: https://github.com/apache/kyuubi/pull/5871#discussion_r1435908399
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -119,6 +119,19 @@ class KyuubiSessionImpl(
engineLastAlive = System.currentTimeMillis()
}
+ def reLaunchEngine(): Unit = handleSessionException {
+ withDiscoveryClient(sessionConf) { discoveryClient =>
+ engine.deregister(
+ discoveryClient,
+ engine.getOrCreate(discoveryClient, launchEngineOp.getOperationLog))
+ }
+ _client.closeSession()
+ engineLaunched = false
+ launchEngineOp = sessionManager.operationManager
+ .newLaunchEngineOperation(this, shouldRunAsync = false)
+ runOperation(launchEngineOp)
Review Comment:
We may not be able to use the `lock` of `_client` because `_client` will be
assigned a new object after this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
