bowenliang123 commented on PR #5871: URL: https://github.com/apache/kyuubi/pull/5871#issuecomment-1868876282
I have some concerns and suggestions, 1. separate two features in each PR, which are not coupled with each other. 2. clarify the gap between description and implementation , as the title and description says `de-register engine` while it implements `re-start engine` 3. describe the design and reason why we have to have `restarting engine`, which is not that reasonable to me 4. is that reslaunching engine a sync operation, and what happen if the restaring engine breaks the timeouts for either launching or session 5. authorization first. What happens if the current engine is used by other sessions even after deregisted. In what case and combination situation allows one to restart the engine? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
