pan3793 commented on PR #5925: URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1870000216
would it be clear if we replace the `queries` and `filter` with `include`(list) and `exclude`(list)? it's kind of a developer tool, such breaking changes are acceptable. for priority, especially when `include` and `exclude` are present at the same timeļ¼ there are some candidates: 1. the final result is `include` minus `exclude` 2. as you proposed, simply ignore the `include` I lean to option 1, but both are fine, as long as we document the behavior clearly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
