pan3793 commented on code in PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#discussion_r1437047673
##########
dev/kyuubi-tpcds/src/main/scala/org/apache/kyuubi/tpcds/benchmark/RunBenchmark.scala:
##########
@@ -66,11 +63,16 @@ object RunBenchmark {
opt[String]('r', "results-dir")
.action((x, c) => c.copy(resultsDir = x))
.text("dir to store benchmark results, e.g. hdfs://hdfs-nn:9870/pref")
- opt[String]('q', "queries")
+ opt[String]('I', "include")
Review Comment:
the short opt is confusing, let's keep the long one only
##########
dev/kyuubi-tpcds/README.md:
##########
@@ -48,14 +48,15 @@ $SPARK_HOME/bin/spark-submit \
Support options:
-| key | default | description
|
-|-------------|------------------------|---------------------------------------------------------------|
-| db | none(required) | the TPC-DS database
|
-| benchmark | tpcds-v2.4-benchmark | the name of application
|
-| iterations | 3 | the number of iterations to run
|
-| breakdown | false | whether to record breakdown results
of an execution |
-| filter | a | filter on the name of the queries to
run, e.g. q1-v2.4 |
-| results-dir | /spark/sql/performance | dir to store benchmark results, e.g.
hdfs://hdfs-nn:9870/pref |
+| key | default | description
|
+|-------------|------------------------|-----------------------------------------------------------------------|
+| db | none(required) | the TPC-DS database
|
+| benchmark | tpcds-v2.4-benchmark | the name of application
|
+| iterations | 3 | the number of iterations to run
|
+| breakdown | false | whether to record breakdown results
of an execution |
+| results-dir | /spark/sql/performance | dir to store benchmark results, e.g.
hdfs://hdfs-nn:9870/pref |
+| include | none(optional) | name of the queries to run, use ,
split multiple name, e.g. q1,q2 |
+| exclude | none(optional) | name of the queries to exclude, use ,
split multiple name, e.g. q2,q4 |
Review Comment:
```suggestion
| include | none(optional) | name of the queries to run, use
comma split multiple name, e.g. q1,q2 |
| exclude | none(optional) | name of the queries to exclude, use
comma split multiple name, e.g. q2,q4 |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
