pan3793 commented on PR #5868: URL: https://github.com/apache/kyuubi/pull/5868#issuecomment-1870365520
Tested locally with https://github.com/awesome-kyuubi/hadoop-testing overall LGTM, some minor things nice to have (it depends on you to fix it in-place or postpone the follow-up PRs) <img width="1933" alt="image" src="https://github.com/apache/kyuubi/assets/26535726/4615602a-6feb-4d76-ab07-03de20d59f45";> 1. we should support proxy user as spark engine does (should be an independent PR) 2. can we use the same rule to generate the engine app name 3. maybe engine type should be KYUUBI ? 4. set the tags, especially engine_ref_id, so that Kyuubi server could find it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
