pan3793 commented on code in PR #5868:
URL: https://github.com/apache/kyuubi/pull/5868#discussion_r1437109559
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/hive/HiveProcessBuilder.scala:
##########
@@ -113,7 +114,24 @@ class HiveProcessBuilder(
override def shortName: String = "hive"
}
-object HiveProcessBuilder {
+object HiveProcessBuilder extends Logging {
final val HIVE_HADOOP_CLASSPATH_KEY = "HIVE_HADOOP_CLASSPATH"
final val HIVE_ENGINE_NAME = "hive.engine.name"
+
+ def apply(
+ appUser: String,
+ conf: KyuubiConf,
+ engineRefId: String,
+ extraEngineLog: Option[OperationLog]): HiveProcessBuilder = {
+ val modeStr = conf.get(ENGINE_DEPLOY_MODE)
+ DeployMode.fromString(conf.get(ENGINE_DEPLOY_MODE)) match {
+ case LocalMode => new HiveProcessBuilder(appUser, conf, engineRefId,
extraEngineLog)
+ case YarnMode =>
+ warn(s"Hive on YARN model is experimental, please use it carefully. " +
+ s"Set `${ENGINE_DEPLOY_MODE.key}` to `${LocalMode.toString}` " +
+ s"if you want to use it on production.")
Review Comment:
both are experimental ...
```suggestion
warn(s"Hive on YARN model is experimental。")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
