SwordyZhao commented on code in PR #5993:
URL: https://github.com/apache/kyuubi/pull/5993#discussion_r1458410721
##########
extensions/spark/kyuubi-spark-lineage/src/main/scala/org/apache/kyuubi/plugin/lineage/dispatcher/atlas/AtlasClientConf.scala:
##########
@@ -21,12 +21,16 @@ import org.apache.atlas.ApplicationProperties
import org.apache.commons.configuration.Configuration
import org.apache.spark.kyuubi.lineage.SparkContextHelper
+import java.util
+
class AtlasClientConf(configuration: Configuration) {
def get(entry: ConfigEntry): String = {
configuration.getProperty(entry.key) match {
case s: String => s
case l: List[_] => l.mkString(",")
+ case jl: util.List[_] => val jlString = jl.toString
Review Comment:
I thought there would be scala's List configuration, so I didn't delete the
original code, and now it doesn't seem to be used.
I have tested your change in the test environment, and it can run perfectly,
so modify it according to your way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
