pan3793 commented on code in PR #5993:
URL: https://github.com/apache/kyuubi/pull/5993#discussion_r1458905666
##########
extensions/spark/kyuubi-spark-lineage/src/main/scala/org/apache/kyuubi/plugin/lineage/dispatcher/atlas/AtlasClientConf.scala:
##########
@@ -21,12 +21,16 @@ import org.apache.atlas.ApplicationProperties
import org.apache.commons.configuration.Configuration
import org.apache.spark.kyuubi.lineage.SparkContextHelper
+import java.util
+
class AtlasClientConf(configuration: Configuration) {
def get(entry: ConfigEntry): String = {
configuration.getProperty(entry.key) match {
case s: String => s
case l: List[_] => l.mkString(",")
+ case jl: util.List[_] => val jlString = jl.toString
Review Comment:
yea, the altas configuration is a pure Java class, which should not involve
Scala collection. could you update and push your change then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
