AngersZhuuuu commented on code in PR #5972:
URL: https://github.com/apache/kyuubi/pull/5972#discussion_r1462652430
##########
extensions/spark/kyuubi-spark-authz/src/main/resources/table_command_spec.json:
##########
@@ -2033,7 +2033,17 @@
} ],
"opType" : "QUERY",
"queryDescs" : [ ],
- "uriDescs" : [ ]
+ "uriDescs" : [ {
+ "fieldName" : "clone",
+ "fieldExtractor" : "HudiCallProcedureInputUriExtractor",
+ "isInput" : true,
+ "comment" : "Hudi"
Review Comment:
I think we don't need to add this here, better in the whole hudi node.
##########
extensions/spark/kyuubi-spark-authz/src/main/resources/table_command_spec.json:
##########
@@ -2033,7 +2033,17 @@
} ],
"opType" : "QUERY",
"queryDescs" : [ ],
- "uriDescs" : [ ]
+ "uriDescs" : [ {
+ "fieldName" : "clone",
+ "fieldExtractor" : "HudiCallProcedureInputUriExtractor",
+ "isInput" : true,
+ "comment" : "Hudi"
+ }, {
+ "fieldName" : "clone",
+ "fieldExtractor" : "HudiCallProcedureOutputUriExtractor",
+ "isInput" : false,
+ "comment" : "Hudi"
Review Comment:
ditto
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/gen/HudiCommands.scala:
##########
@@ -288,7 +288,14 @@ object HudiCommands extends CommandSpecs[TableCommandSpec]
{
"clone",
classOf[HudiCallProcedureOutputTableExtractor],
actionTypeDesc = Some(ActionTypeDesc(actionType = Some(UPDATE))),
- setCurrentDatabaseIfMissing = true)))
+ setCurrentDatabaseIfMissing = true)),
+ uriDescs = Seq(
+ UriDesc(
+ "clone",
+ classOf[HudiCallProcedureInputUriExtractor],
+ isInput = true,
+ comment = "Hudi"),
+ UriDesc("clone", classOf[HudiCallProcedureOutputUriExtractor], comment
= "Hudi")))
Review Comment:
ditto, can remove hudi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
