Yikf commented on code in PR #5972:
URL: https://github.com/apache/kyuubi/pull/5972#discussion_r1462939386
##########
extensions/spark/kyuubi-spark-authz/src/main/resources/table_command_spec.json:
##########
@@ -2033,7 +2033,17 @@
} ],
"opType" : "QUERY",
"queryDescs" : [ ],
- "uriDescs" : [ ]
+ "uriDescs" : [ {
+ "fieldName" : "clone",
+ "fieldExtractor" : "HudiCallProcedureInputUriExtractor",
+ "isInput" : true,
+ "comment" : "Hudi"
Review Comment:
As far as I know, the comment field is only used for [error
output](https://github.com/apache/kyuubi/blob/ac388d191ddb6a910a5c74575d3ba6aa5a31e062/extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/Descriptor.scala#L64)(maybe
I missed something 👽), So I don't understand what the purpose of deleting this
field is?
BTW, the top level CommandSpec has no comment field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
