pan3793 commented on code in PR #6273:
URL: https://github.com/apache/kyuubi/pull/6273#discussion_r1555155472
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/FetchOrcStatement.scala:
##########
@@ -76,27 +75,13 @@ class FetchOrcStatement(spark: SparkSession) {
private def getOrcDeserializer(orcSchema: StructType, colId: Array[Int]):
OrcDeserializer = {
try {
- if (SPARK_ENGINE_RUNTIME_VERSION >= "3.2") {
- // SPARK-34535 changed the constructor signature of OrcDeserializer
- DynConstructors.builder()
- .impl(classOf[OrcDeserializer], classOf[StructType],
classOf[Array[Int]])
- .build[OrcDeserializer]()
- .newInstance(
- orcSchema,
- colId)
- } else {
- DynConstructors.builder()
- .impl(
- classOf[OrcDeserializer],
- classOf[StructType],
- classOf[StructType],
- classOf[Array[Int]])
- .build[OrcDeserializer]()
- .newInstance(
- new StructType,
- orcSchema,
- colId)
- }
+ // SPARK-34535 changed the constructor signature of OrcDeserializer
+ DynConstructors.builder()
Review Comment:
we don't need reflection then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
