pan3793 commented on code in PR #6273:
URL: https://github.com/apache/kyuubi/pull/6273#discussion_r1555156507
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/sql/kyuubi/SparkDatasetHelper.scala:
##########
@@ -223,30 +210,6 @@ object SparkDatasetHelper extends Logging {
spark.sessionState.conf.sessionLocalTimeZone).toArray
}
- /**
- * This method provides a reflection-based implementation of
- * [[AdaptiveSparkPlanExec.finalPhysicalPlan]] that enables us to adapt to
the Spark runtime
- * without patching SPARK-41914.
- *
- * TODO: Once we drop support for Spark 3.1.x, we can directly call
- * [[AdaptiveSparkPlanExec.finalPhysicalPlan]].
- */
- def finalPhysicalPlan(adaptiveSparkPlanExec: AdaptiveSparkPlanExec):
SparkPlan = {
- withFinalPlanUpdate(adaptiveSparkPlanExec, identity)
- }
-
- /**
- * A reflection-based implementation of
[[AdaptiveSparkPlanExec.withFinalPlanUpdate]].
- */
- private def withFinalPlanUpdate[T](
- adaptiveSparkPlanExec: AdaptiveSparkPlanExec,
- fun: SparkPlan => T): T = {
- val plan = invokeAs[SparkPlan](adaptiveSparkPlanExec,
"getFinalPhysicalPlan")
- val result = fun(plan)
- invokeAs[Unit](adaptiveSparkPlanExec, "finalPlanUpdate")
- result
- }
-
/**
* offset support was add since Spark-3.4(set SPARK-28330), to ensure
backward compatibility with
Review Comment:
```suggestion
* offset support was add in SPARK-28330(3.4.0), to ensure backward
compatibility with
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
