pan3793 commented on code in PR #6275:
URL: https://github.com/apache/kyuubi/pull/6275#discussion_r1560834041
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/JdbcSQLEngine.scala:
##########
@@ -66,15 +72,45 @@ object JdbcSQLEngine extends Logging {
def main(args: Array[String]): Unit = {
SignalRegister.registerLogger(logger)
-
try {
Utils.fromCommandLineArgs(args, kyuubiConf)
kyuubiConf.setIfMissing(KyuubiConf.FRONTEND_THRIFT_BINARY_BIND_PORT, 0)
kyuubiConf.setIfMissing(HA_ZK_CONN_RETRY_POLICY,
RetryPolicies.N_TIME.toString)
+ val proxyUser =
kyuubiConf.getOption(KyuubiReservedKeys.KYUUBI_SESSION_USER_KEY)
+ require(proxyUser.isDefined,
s"${KyuubiReservedKeys.KYUUBI_SESSION_USER_KEY} is not set")
+ val realUser = UserGroupInformation.getLoginUser
+ val principal = kyuubiConf.get(ENGINE_PRINCIPAL)
+ val keytab = kyuubiConf.get(ENGINE_KEYTAB)
- startEngine()
+ val ugi = DeployMode.withName(kyuubiConf.get(ENGINE_JDBC_DEPLOY_MODE))
match {
+ case DeployMode.LOCAL
+ if UserGroupInformation.isSecurityEnabled && principal.isDefined
&& keytab.isDefined =>
+ UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get)
+ UserGroupInformation.getCurrentUser
+ case DeployMode.LOCAL if proxyUser.get != realUser.getShortUserName =>
+ val newUGI = UserGroupInformation.createProxyUser(proxyUser.get,
realUser)
+ newUGI.doAs(new PrivilegedExceptionAction[Unit] {
+ override def run(): Unit = {
+ val engineCredentials =
+
kyuubiConf.getOption(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY)
+
kyuubiConf.unset(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY)
+ engineCredentials.filter(_.nonEmpty).foreach { credentials =>
+ }
Review Comment:
why keep a empty body here?
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/JdbcSQLEngine.scala:
##########
@@ -66,15 +72,45 @@ object JdbcSQLEngine extends Logging {
def main(args: Array[String]): Unit = {
SignalRegister.registerLogger(logger)
-
try {
Utils.fromCommandLineArgs(args, kyuubiConf)
kyuubiConf.setIfMissing(KyuubiConf.FRONTEND_THRIFT_BINARY_BIND_PORT, 0)
kyuubiConf.setIfMissing(HA_ZK_CONN_RETRY_POLICY,
RetryPolicies.N_TIME.toString)
+ val proxyUser =
kyuubiConf.getOption(KyuubiReservedKeys.KYUUBI_SESSION_USER_KEY)
+ require(proxyUser.isDefined,
s"${KyuubiReservedKeys.KYUUBI_SESSION_USER_KEY} is not set")
+ val realUser = UserGroupInformation.getLoginUser
+ val principal = kyuubiConf.get(ENGINE_PRINCIPAL)
+ val keytab = kyuubiConf.get(ENGINE_KEYTAB)
- startEngine()
+ val ugi = DeployMode.withName(kyuubiConf.get(ENGINE_JDBC_DEPLOY_MODE))
match {
+ case DeployMode.LOCAL
+ if UserGroupInformation.isSecurityEnabled && principal.isDefined
&& keytab.isDefined =>
+ UserGroupInformation.loginUserFromKeytab(principal.get, keytab.get)
+ UserGroupInformation.getCurrentUser
+ case DeployMode.LOCAL if proxyUser.get != realUser.getShortUserName =>
+ val newUGI = UserGroupInformation.createProxyUser(proxyUser.get,
realUser)
+ newUGI.doAs(new PrivilegedExceptionAction[Unit] {
+ override def run(): Unit = {
+ val engineCredentials =
+
kyuubiConf.getOption(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY)
+
kyuubiConf.unset(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY)
+ engineCredentials.filter(_.nonEmpty).foreach { credentials =>
+ }
Review Comment:
why keep an empty body here? let's make the code as simple as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
