pan3793 commented on code in PR #6275:
URL: https://github.com/apache/kyuubi/pull/6275#discussion_r1560840977
##########
externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/deploy/HiveYarnModeSubmitter.scala:
##########
@@ -60,18 +61,10 @@ object HiveYarnModeSubmitter extends
EngineYarnModeSubmitter {
jars.toSeq
}
- private[hive] def parseClasspath(classpath: String, jars: ListBuffer[File]):
Unit = {
- classpath.split(":").filter(_.nonEmpty).foreach { cp =>
- if (cp.endsWith("/*")) {
- val dir = cp.substring(0, cp.length - 2)
- new File(dir) match {
- case f if f.isDirectory =>
- f.listFiles().filter(_.getName.endsWith(".jar")).foreach(jars += _)
- case _ =>
- }
- } else {
- jars += new File(cp)
- }
- }
+ override def listConfFiles(): Seq[File] = {
+ // respect the following priority loading configuration, and distinct files
+ // hive configuration -> hadoop configuration -> yarn configuration
Review Comment:
please supply similar message on the super method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
