pan3793 commented on code in PR #6587:
URL: https://github.com/apache/kyuubi/pull/6587#discussion_r1726165888
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionManager.scala:
##########
@@ -97,7 +98,8 @@ class KyuubiSessionManager private (name: String) extends
SessionManager(name) {
this,
userConf,
userConf.get(ENGINE_DO_AS_ENABLED),
- parser)
+ parser,
+ tempFileService = kyuubiServer.tempFileService)
Review Comment:
looks like the `parser` is an exception here. we don't need to pass a global
sharable instance into each session, that makes us clear to know we are
touching a sharable or session-isolated instance
for exmaple
```
class KyuubiSessionImpl {
sessionManager.abc // we are touching a sharable instance
conf.xxx // we are touching a session-isolated instance
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
