bowenliang123 commented on code in PR #6587: URL: https://github.com/apache/kyuubi/pull/6587#discussion_r1726438035
########## kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala: ########## @@ -118,6 +118,10 @@ class KyuubiSessionImpl( // we should call super.open before running launch engine operation super.open() + operationalLogRootDir.foreach { dir => + Option(sessionManager.tempFileService).foreach(_.addPathToExpiration(dir)) Review Comment: Yes. You're right. `sessionManager.tempFileService` is always present, let me skip the option wrapper here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org