bowenliang123 commented on code in PR #6213:
URL: https://github.com/apache/kyuubi/pull/6213#discussion_r1805756758


##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/JdbcConnectionParams.java:
##########
@@ -79,6 +79,7 @@ public class JdbcConnectionParams {
   // Use ZooKeeper for indirection while using dynamic service discovery
   static final String SERVICE_DISCOVERY_MODE_ZOOKEEPER = "zooKeeper";
   static final String ZOOKEEPER_NAMESPACE = "zooKeeperNamespace";
+  static final String ZOOKEEPER_STRATEGY = "zooKeeperStrategy";

Review Comment:
   ```suggestion
     static final String ZOOKEEPER_SELECT_POLICY = "zooKeeperSelectPolicy";
   ```
   Would it be a better name for the parameter? cc @pan3793 
   The term `select policy` is similar with existed config 
`kyuubi.engine.pool.selectPolicy` of kyuubi server.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org

Reply via email to