pan3793 commented on code in PR #6213:
URL: https://github.com/apache/kyuubi/pull/6213#discussion_r1811711937
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/JdbcConnectionParams.java:
##########
@@ -79,6 +79,7 @@ public class JdbcConnectionParams {
// Use ZooKeeper for indirection while using dynamic service discovery
static final String SERVICE_DISCOVERY_MODE_ZOOKEEPER = "zooKeeper";
static final String ZOOKEEPER_NAMESPACE = "zooKeeperNamespace";
+ static final String ZOOKEEPER_STRATEGY = "zooKeeperStrategy";
Review Comment:
"select policy" is a better phrase here.
technically, the mechanism could be promoted to another service discovery
impls, so we should not include "zookeeper" in the parameter name.
so my suggested parameter name is "serverSelectPolicy", and also rename
interface "ChooseServerStrategy" to "ServerSelectStrategy"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
