turboFei commented on code in PR #7011:
URL: https://github.com/apache/kyuubi/pull/7011#discussion_r2026423016
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -167,18 +167,21 @@ class KyuubiSessionImpl(
warn(s"Error on de-registering engine [${engine.engineSpace}
$host:$port]", e)
}
+ var engineClient: KyuubiSyncThriftClient = null
try {
val passwd =
if (sessionManager.getConf.get(ENGINE_SECURITY_ENABLED)) {
InternalSecurityAccessor.get().issueToken()
} else {
Option(password).filter(_.nonEmpty).getOrElse("anonymous")
}
- _client = KyuubiSyncThriftClient.createClient(user, passwd, host,
port, sessionConf)
+ engineClient =
+ KyuubiSyncThriftClient.createClient(user, passwd, host, port,
sessionConf)
Review Comment:
FYI:
```
2025-04-02 21:06:10.785 ERROR [pool-11-thread-1]
org.apache.kyuubi.ebay.carmel.gateway.session.CarmelSessionStateChecker: Failed
to check carmel session status SessionHandle
[54ce2fb6-db99-4caf-ab0a-e17c60e4cc5c], retry 3
: java.lang.NullPointerException: Cannot invoke
"org.apache.kyuubi.shaded.hive.service.rpc.thrift.TSessionHandle.getSessionId()"
because "tHandle" is null
at
org.apache.kyuubi.session.SessionHandle$.apply(SessionHandle.scala:38)
at
org.apache.kyuubi.client.KyuubiSyncThriftClient.asyncRequestExecutor$lzycompute(KyuubiSyncThriftClient.scala:78)
at
org.apache.kyuubi.client.KyuubiSyncThriftClient.asyncRequestExecutor(KyuubiSyncThriftClient.scala:75)
at
org.apache.kyuubi.client.KyuubiSyncThriftClient.$anonfun$withLockAcquiredAsyncRequest$1(KyuubiSyncThriftClient.scala:164)
at
org.apache.kyuubi.client.KyuubiSyncThriftClient.$anonfun$withLockAcquired$1(KyuubiSyncThriftClient.scala:160)
at org.apache.kyuubi.Utils$.withLockRequired(Utils.scala:392)
at
org.apache.kyuubi.client.KyuubiSyncThriftClient.withLockAcquired(KyuubiSyncThriftClient.scala:156)
at
org.apache.kyuubi.client.KyuubiSyncThriftClient.withLockAcquiredAsyncRequest(KyuubiSyncThriftClient.scala:163)
at
org.apache.kyuubi.client.KyuubiSyncThriftClient.getInfo(KyuubiSyncThriftClient.scala:278)
at
org.apache.kyuubi.ebay.carmel.gateway.session.CarmelSessionStateChecker$$anon$1.$anonfun$call$1(CarmelSessionStateChecker.scala:48)
at scala.Option.map(Option.scala:230)
at
org.apache.kyuubi.ebay.carmel.gateway.session.CarmelSessionStateChecker$$anon$1.call(CarmelSessionStateChecker.scala:47)
at
org.apache.kyuubi.ebay.carmel.gateway.session.CarmelSessionStateChecker$$anon$1.call(CarmelSessionStateChecker.scala:41)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
