turboFei commented on code in PR #7011:
URL: https://github.com/apache/kyuubi/pull/7011#discussion_r2026427497
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -167,18 +167,21 @@ class KyuubiSessionImpl(
warn(s"Error on de-registering engine [${engine.engineSpace}
$host:$port]", e)
}
+ var engineClient: KyuubiSyncThriftClient = null
try {
val passwd =
if (sessionManager.getConf.get(ENGINE_SECURITY_ENABLED)) {
InternalSecurityAccessor.get().issueToken()
} else {
Option(password).filter(_.nonEmpty).getOrElse("anonymous")
}
- _client = KyuubiSyncThriftClient.createClient(user, passwd, host,
port, sessionConf)
+ engineClient =
+ KyuubiSyncThriftClient.createClient(user, passwd, host, port,
sessionConf)
Review Comment:
The `client` might be exposed before it is ready(before openSession).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
