pan3793 commented on code in PR #7123:
URL: https://github.com/apache/kyuubi/pull/7123#discussion_r2185683697
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/HiveTable.scala:
##########
@@ -77,7 +93,10 @@ case class HiveTable(
}
override def newScanBuilder(options: CaseInsensitiveStringMap): ScanBuilder
= {
- HiveScanBuilder(sparkSession, fileIndex, dataSchema, catalogTable)
+ finalTableType match {
+ case Some("ORC") => OrcScanBuilder(sparkSession, fileIndex, schema,
dataSchema, options)
Review Comment:
the conversion is not always compatible, you must have a switch to allow
user to disable it.
for the built-in V1 Hive ORC tables, Spark has a
`spark.sql.hive.convertMetastoreOrc`, we can have a
`spark.sql.kyuubi.hive.connector.convertMetastoreOrc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
