pan3793 commented on code in PR #7123:
URL: https://github.com/apache/kyuubi/pull/7123#discussion_r2185685055
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/HiveTable.scala:
##########
@@ -59,6 +61,20 @@ case class HiveTable(
catalogTable.stats.map(_.sizeInBytes.toLong).getOrElse(defaultTableSize))
}
+ lazy val finalTableType: Option[String] = {
+ val serde =
catalogTable.storage.serde.getOrElse("").toLowerCase(Locale.ROOT)
+ val parquet = serde.contains("parquet")
+ val orc = serde.contains("orc")
+ val provider = catalogTable.provider.map(_.toUpperCase(Locale.ROOT))
Review Comment:
why lowercase `serde` but uppercase `provider`? can we have a consistent
style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
