Copilot commented on code in PR #7132:
URL: https://github.com/apache/kyuubi/pull/7132#discussion_r2196093605
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala:
##########
@@ -292,13 +292,21 @@ class BatchJobSubmission(
try {
info(s"Submitting $batchType batch[$batchId] job:\n$builder")
val process = builder.start
- while (process.isAlive && !applicationFailed(_applicationInfo,
appOperation)) {
+ while (process.isAlive &&
Review Comment:
[nitpick] The combined negated condition is a bit hard to follow. Consider
extracting it to a well-named helper (e.g., `shouldContinuePolling`) or
rewriting as `while (process.isAlive && (!applicationId(...).isDefined ||
!applicationFailed(...)))` for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
