pan3793 commented on code in PR #7132:
URL: https://github.com/apache/kyuubi/pull/7132#discussion_r2196664255
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala:
##########
@@ -372,6 +372,25 @@ class SparkProcessBuilder(
private[spark] def engineLogPathConf(): Map[String, String] = {
Map(KYUUBI_ENGINE_LOG_PATH_KEY -> engineLog.getAbsolutePath)
}
+
+ private[spark] def getSparkOption(key: String): Option[String] = {
+
conf.getOption(KUBERNETES_NAMESPACE_KEY).orElse(defaultsConf.get(KUBERNETES_NAMESPACE_KEY))
+ }
+
+ override def waitEngineCompletion: Boolean = {
+ !isClusterMode() ||
getSparkOption(KyuubiConf.SESSION_ENGINE_STARTUP_WAIT_COMPLETION.key)
+
.getOrElse(KyuubiConf.SESSION_ENGINE_STARTUP_WAIT_COMPLETION.defaultValStr)
+ .toBoolean
+ }
+
+ def engineWaitCompletionConf(): Map[String, String] =
+ clusterManager().map(_.toLowerCase(Locale.ROOT)) match {
+ case Some(m) if m.startsWith("yarn") =>
+ Map(YARN_SUBMIT_WAIT_APP_COMPLETION -> waitEngineCompletion.toString)
+ case Some(m) if m.startsWith("k8s") =>
+ Map(KUBERNETES_SUBMISSION_WAIT_APP_COMPLETION ->
waitEngineCompletion.toString)
Review Comment:
this is a behavior change, could you document it on migration guide?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
