pan3793 commented on code in PR #7132:
URL: https://github.com/apache/kyuubi/pull/7132#discussion_r2199575351
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala:
##########
@@ -79,7 +79,18 @@ class BatchJobSubmission(
def appStartTime: Long = _appStartTime
def appStarted: Boolean = _appStartTime > 0
- private lazy val _submitTime = if (appStarted) _appStartTime else
System.currentTimeMillis
+ private lazy val _submitTime = System.currentTimeMillis
+ private lazy val waitEngineCompletion = builder.waitEngineCompletion
+ private def submitTime: Long = if (appStarted) {
Review Comment:
could you add comments to clarify the meaning of `appStartTime`,
`appStarted`, `submitTime`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
