ryanbordo commented on code in PR #7300:
URL: https://github.com/apache/kyuubi/pull/7300#discussion_r2772361040
##########
python/pyhive/hive.py:
##########
@@ -236,6 +240,8 @@ def __init__(
if auth is None:
auth = 'NONE'
socket = thrift.transport.TSocket.TSocket(host, port)
+ if connection_timeout:
+ socket.setTimeout(connection_timeout)
Review Comment:
The connection from the `thrift_transport` actually doesn't need to be
established. And in our dbt code, we have a
[path](https://github.com/dbt-labs/dbt-adapters/blob/b9ebd240e39882a8c43ed659de423c7504d4642a/dbt-spark/src/dbt/adapters/spark/connections.py#L533)
that relies on this connection being opened in `hive.connect` function.
Unfortunately, the case for passing a transport object is ambiguous since
thrift python only has one `setTimeout` for both. It might make sense to skip
both timeouts when a transport is passed? Regardless, I'll get started on the
proposal you sent but let me know if you have any additional thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
