pan3793 commented on code in PR #7300:
URL: https://github.com/apache/kyuubi/pull/7300#discussion_r2772382219
##########
python/pyhive/hive.py:
##########
@@ -236,6 +240,8 @@ def __init__(
if auth is None:
auth = 'NONE'
socket = thrift.transport.TSocket.TSocket(host, port)
+ if connection_timeout:
+ socket.setTimeout(connection_timeout)
Review Comment:
okay, I read the code, `self._transport.open()` happens in Connection
`__init__`, so we can call `setTimeout(connect_time)` before it, and call
`setTimeout(socket_time)`, same for both host/port and thrift_transport cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
