LamiumAmplexicaule commented on code in PR #7451:
URL: https://github.com/apache/kyuubi/pull/7451#discussion_r3246916626
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/Utils.scala:
##########
@@ -325,17 +325,10 @@ object Utils extends Logging {
def redactCommandLineArgs(conf: KyuubiConf, commands: Iterable[String]):
Iterable[String] = {
conf.get(SERVER_SECRET_REDACTION_PATTERN) match {
case Some(redactionPattern) =>
- var nextKV = false
commands.map {
- case PATTERN_FOR_KEY_VALUE_ARG(key, value) if nextKV =>
+ case PATTERN_FOR_KEY_VALUE_ARG(key, value) =>
val (_, newValue) = redact(redactionPattern, Seq((key,
value))).head
- nextKV = false
genKeyValuePair(key, newValue)
-
- case cmd if cmd == CONF =>
- nextKV = true
- cmd
-
Review Comment:
In the test that checks whether the logs in FlinkProcessBuilder are
redacted, I noticed that values in the `-D` format don’t get redacted, so I
removed this filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
