LamiumAmplexicaule commented on code in PR #7451: URL: https://github.com/apache/kyuubi/pull/7451#discussion_r3247183548
########## kyuubi-server/src/main/scala/org/apache/kyuubi/engine/dataagent/DataAgentProcessBuilder.scala: ########## @@ -34,6 +34,7 @@ import org.apache.kyuubi.operation.log.OperationLog import org.apache.kyuubi.util.command.CommandLineUtils._ class DataAgentProcessBuilder( + override val serverConf: KyuubiConf, Review Comment: Thank you for your comments. My understanding is that the reason redaction no longer happens after #7054 is that, in https://github.com/apache/kyuubi/blob/e769f4239891536e9850c11b9661ea65d82a01f9/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionManager.scala#L95, the sessionConf passed in has the serverOnly configs stripped out. If we want to obtain `kyuubi.server.redaction.regex` from EngineRef/ without passing serverConf, we need to explicitly set it somewhere. However, it feels wrong to propagate server-side config into the session/engine configs, so I chose the approach of passing serverConf instead. When passing conf as serverConf, if we strip out everything except serverOnly, we might avoid accidentally referencing serverConf. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
