alexandrefimov commented on issue #7511: URL: https://github.com/apache/kyuubi/issues/7511#issuecomment-5333761544
The gateway import reached the routing core: [apache/spark-connect-gateway#3](https://github.com/apache/spark-connect-gateway/pull/3) adds `crates/routing/src/lib.rs`, and the extension point that USER share level needs is in it. `SelectionStrategy::select` takes the full `SessionKey`, and `BackendMember` carries a free-form `labels` map, so a strategy can match the session identity against a backend's owner. The default `RoundRobinStrategy` ignores both — its doc comment says so — and the comment on `BackendMember` notes that the K8s watcher supplies addresses only, with pod-label surfacing still to do. That settles the sub-question I parked in the design, whether the engine attributes need an explicit owner label. The two shipping pools are static config and a K8s Endpoints watch, and neither reads our ZK path, so the owner has to reach the gateway as a member label from whatever discovery source it runs on — `BackendMember.labels` is where a strategy would read it. I'd take the user-aware strategy and the label surfacing to that repo once the crate is merged. On the Kyuubi slice, open question 2 I can answer myself now. Once SPARK-58658 lands, the Config RPC read-back is closed for our keys by the `spark.redaction.regex` append in `SparkSQLEngine.scala:273-276`, so a generated token file buys only `ps` hygiene; my default for the first slice is a per-engine token via `--conf` and no file. Questions 1, 3 and 4 are still yours to call. Shall I start on the engine-side tasks and bring 1, 3 and 4 as concrete choices in the PR, or would you rather settle them here first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
