alexandrefimov commented on issue #7511: URL: https://github.com/apache/kyuubi/issues/7511#issuecomment-5449867589
Starting on the engine side. PR1 is the engine starting Connect plus the deployment page; discovery attributes, Connect-aware idle and drain, and generating the token at launch follow as separate PRs in that order. I am reading your answers to 1, 3 and 4 as the contract for the frontend when it lands rather than for this slice — inside the engine the RPC surface, the module boundary and the execution identity are Spark's own, as the design doc describes — and taking the slice itself as you scoped it on 6 August. Two things in PR1 depart from that design doc. It probes for `Connect.getAuthenticateToken` instead of gating on `SPARK_ENGINE_RUNTIME_VERSION >= "4.0"`; the effect on 3.5 is the same — no token support, so the engine refuses to start — but it is feature detection rather than a version comparison, which is what `AGENTS.md` asks for. And `kyuubi.engine.spark.connect.enabled` is immutable: enabling Connect opens a channel the server's `kyuubi.session.conf.restrict.list` never sees, so I would rather an administrator made that call than a JDBC connection string. Say if you would rather have it session-settable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
