pan3793 commented on code in PR #7792:
URL: https://github.com/apache/kyuubi/pull/7792#discussion_r4399498800
##########
extensions/spark/kyuubi-spark-lineage/src/main/scala/org/apache/kyuubi/plugin/lineage/helper/SparkSQLLineageParseHelper.scala:
##########
@@ -204,6 +205,13 @@ trait LineageParser {
parentColumnsLineage: AttributeMap[AttributeSet],
inputTablesByPlan: mutable.HashSet[String]): AttributeMap[AttributeSet]
= {
+ if
(!SparkContextHelper.getConf(LineageConf.LEGACY_COLLECT_INPUT_TABLES_ENABLED)) {
Review Comment:
`SparkContextHelper.getConf` goes through `SparkContext.getConf`, which
clones the whole `SparkConf`, and this now runs at every plan node, subqueries
included. Could we read the flag once in `parse` and pass it down to
`extractColumnsLineage`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
