Kami commented on a change in pull request #1592:
URL: https://github.com/apache/libcloud/pull/1592#discussion_r746800479



##########
File path: libcloud/common/ovh.py
##########
@@ -226,7 +226,7 @@ def 
handle_and_rethrow_user_friendly_invalid_region_error(host, e):
     """
     msg = str(e).lower()
 
-    if 'name or service not known' in msg or 'getaddrinfo failed' in msg:
+    if 'nodename nor servname provided, or not known' in msg or 'getaddrinfo 
failed' in msg:

Review comment:
       I needed to make a small change to get tests to pass (aka also check for 
``'name or service not known' ``). I do agree that checking the error message 
is not the most robust approach though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to