Germandrummer92 commented on pull request #1592: URL: https://github.com/apache/libcloud/pull/1592#issuecomment-965555443
Yes, but there is another important change: Before the retry was only wrapping the raw requests request which actually doesn't raise any exception, since we don't explicitly call ```raise_for_status```, instead now it also wraps the creation of the responseCls (line 677 in common/base.py), in which the actual exception is raised (line 166 in common/base.py). So I actually think the retry wasn't very helpful before since the http exceptions weren't thrown. I will take a look at the failing tests now, they worked for me locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
