Kami commented on code in PR #1983:
URL: https://github.com/apache/libcloud/pull/1983#discussion_r1581834020
##########
libcloud/compute/drivers/kubevirt.py:
##########
@@ -391,63 +772,162 @@ def create_node(
)
raise KeyError(msg)
+ claim_name = disk["volume_spec"]["claim_name"]
+
+ if claim_name not in
self.ex_list_persistent_volume_claims(namespace=namespace):
+ if (
+ "size" not in disk["volume_spec"]
+ or "storage_class_name" not in disk["volume_spec"]
+ ):
+ msg = (
Review Comment:
Do we have test cases which cover this scenario + all other regular + edge
cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
